Skip to content

fix: compatible with vue-loader experimentalInlineMatchResource #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

fix: compatible with vue-loader experimentalInlineMatchResource #829

merged 4 commits into from
Feb 25, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 21, 2025

Description

When using vue-loader experimentalInlineMatchResource, the request will have an additional .js/.ts extension to match the js/ts module rule

// without experimentalInlineMatchResource
- src/App.vue?vue&type=script&setup=true&lang=ts
// with experimentalInlineMatchResource
+ src/App.vue.ts?vue&type=script&setup=true&lang=ts

But the default include RegExps failed to match the request

Linked Issues

Additional context

@ahabhgk ahabhgk requested a review from antfu as a code owner February 21, 2025 12:02
@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

chenjiahan
chenjiahan reviewed Feb 22, 2025
View reviewed changes
@ahabhgk @chenjiahan
Update unplugin.ts
0efa06e 
Co-authored-by: neverland <[email protected]>
ahabhgk
ahabhgk commented Feb 22, 2025
View reviewed changes
@chenjiahan
Copy link
Contributor

@antfu Can you take a look at this PR? ❤️

The background of this PR is that the latest version of Rspack aligns with webpack's Inline matchResource implementation, but this change will break users who are already using unplugin-vue-components and vue-loader's experimentalInlineMatchResource option. Therefore, we need to fix the matching through this PR.

@sxzz sxzz merged commit 2f689ee into unplugin:main Feb 25, 2025
6 checks passed
@chenjiahan chenjiahan mentioned this pull request Feb 27, 2025
Merged
@sxzz sxzz mentioned this pull request Feb 28, 2025
Closed
@chenjiahan chenjiahan mentioned this pull request Mar 5, 2025
Closed
@renovate renovate bot mentioned this pull request Mar 12, 2025
Closed
1 task
@Trailblazer587 Trailblazer587 mentioned this pull request Apr 15, 2025
Open
@Arktomson Arktomson mentioned this pull request Jun 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@antfu antfu Awaiting requested review from antfu antfu is a code owner

+1 more reviewer

@chenjiahan chenjiahan chenjiahan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahabhgk @chenjiahan @sxzz